Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should log this warning instead of putsing #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Should log this warning instead of putsing #1

wants to merge 1 commit into from

Conversation

danlucraft
Copy link

No description provided.

@danlucraft danlucraft requested a review from jsundt April 5, 2017 16:41
@danlucraft
Copy link
Author

@jsundt Any thoughts?

jsundt
jsundt approved these changes Apr 6, 2017
View reviewed changes
Copy link

@jsundt jsundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should definitely not be puts 👍

@dannysmith
Copy link

@danlucraft Can we merge or close this PR?

@danlucraft
Copy link
Author

@jsundt hey let’s merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsundt jsundt jsundt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlucraft @dannysmith @jsundt